Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/core/rendering/RenderLayerModelObject.h

Issue 27246003: Replace check for RenderLayer in RenderLayerModelObject::ensureLayer with ASSERT due to redundant c… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed! Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerModelObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. 5 * Copyright (C) 2010, 2012 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // Returns true if the background is painted opaque in the given rect. 52 // Returns true if the background is painted opaque in the given rect.
53 // The query rect is given in local coordinate system. 53 // The query rect is given in local coordinate system.
54 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; } 54 virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const { re turn false; }
55 55
56 // This is null for anonymous renderers. 56 // This is null for anonymous renderers.
57 ContainerNode* node() const { return toContainerNode(RenderObject::node()); } 57 ContainerNode* node() const { return toContainerNode(RenderObject::node()); }
58 58
59 CompositedLayerMapping* compositedLayerMapping() const; 59 CompositedLayerMapping* compositedLayerMapping() const;
60 60
61 protected: 61 protected:
62 void ensureLayer(); 62 void createLayer();
63 63
64 virtual void willBeDestroyed() OVERRIDE; 64 virtual void willBeDestroyed() OVERRIDE;
65 65
66 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE; 66 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer*, co nst LayoutPoint&, const LayoutRect&) const OVERRIDE;
67 67
68 private: 68 private:
69 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; } 69 virtual bool isLayerModelObject() const OVERRIDE FINAL { return true; }
70 70
71 RenderLayer* m_layer; 71 RenderLayer* m_layer;
72 72
(...skipping 15 matching lines...) Expand all
88 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isLayerModelObject()); 88 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isLayerModelObject());
89 return static_cast<const RenderLayerModelObject*>(object); 89 return static_cast<const RenderLayerModelObject*>(object);
90 } 90 }
91 91
92 // This will catch anyone doing an unnecessary cast. 92 // This will catch anyone doing an unnecessary cast.
93 void toRenderLayerModelObject(const RenderLayerModelObject*); 93 void toRenderLayerModelObject(const RenderLayerModelObject*);
94 94
95 } // namespace WebCore 95 } // namespace WebCore
96 96
97 #endif // RenderLayerModelObject_h 97 #endif // RenderLayerModelObject_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698