Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2724483003: Have observatory_tool always invoke pub with no HTTP_PROXY environment variable set (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Have observatory_tool always invoke pub with no HTTP_PROXY environment variable set Fixes #28865 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/6c0a2af761a5015dd35662da884693c115900928

Patch Set 1 #

Patch Set 2 : Have observatory_tool always invoke pub with no HTTP_PROXY environment variable set #

Patch Set 3 : more context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/observatory_tool.py View 1 2 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
3 years, 9 months ago (2017-02-28 15:50:59 UTC) #4
zra
lgtm
3 years, 9 months ago (2017-02-28 15:58:26 UTC) #5
Cutch
3 years, 9 months ago (2017-02-28 16:00:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6c0a2af761a5015dd35662da884693c115900928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698