Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2724473004: Tweak Florian's dart2js inlining heuristic change (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 9 chunks +51 lines, -16 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 9 months ago (2017-02-28 23:41:35 UTC) #4
floitsch
LGTM. https://codereview.chromium.org/2724473004/diff/60001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/2724473004/diff/60001/pkg/compiler/lib/src/ssa/builder.dart#newcode6686 pkg/compiler/lib/src/ssa/builder.dart:6686: // parameter is a constant. Assuming the parameter ...
3 years, 9 months ago (2017-03-01 08:50:15 UTC) #5
sra1
3 years, 9 months ago (2017-03-07 04:33:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
bf9a4502c889d6542e5e1e7b0b72c67c81418336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698