Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2724473002: Add assists to move Flutter widgets up and down one level (Closed)

Created:
3 years, 9 months ago by messick
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO per review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 6 chunks +192 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +102 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
messick
Needs more tests, which will probably reveal problems, which I'll be glad to fix after ...
3 years, 9 months ago (2017-02-28 00:03:07 UTC) #3
Brian Wilkerson
I agree it needs more tests, but still lgtm https://codereview.chromium.org/2724473002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/2724473002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode2424 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:2424: ...
3 years, 9 months ago (2017-02-28 00:14:36 UTC) #4
messick
Committed patchset #2 (id:20001) manually as b3ed30b8220b0a309572fe32f516c991cb8179ed (presubmit successful).
3 years, 9 months ago (2017-02-28 01:03:56 UTC) #6
scheglov
3 years, 9 months ago (2017-02-28 01:07:28 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698