Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 2724433002: Remove the retargeting notification (Closed)
Patch Set: Remove comments in safe browsing tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
index e467d996d21ca4075fa414320189d7c785a18afb..35b22af8ce6e87e5500cec327072f9abf9619482 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
@@ -27,8 +27,6 @@
#include "extensions/browser/event_router.h"
#include "url/gurl.h"
-struct RetargetingDetails;
-
namespace extensions {
// Tab contents observer that forwards navigation events to the event router.
@@ -69,7 +67,8 @@ class WebNavigationTabObserver
const content::Referrer& referrer,
WindowOpenDisposition disposition,
ui::PageTransition transition,
- bool started_from_context_menu) override;
+ bool started_from_context_menu,
+ bool renderer_initiated) override;
void WebContentsDestroyed() override;
// This method dispatches the already created onBeforeNavigate event.
@@ -119,6 +118,17 @@ class WebNavigationEventRouter : public TabStripModelObserver,
explicit WebNavigationEventRouter(Profile* profile);
~WebNavigationEventRouter() override;
+ // Router level handler for the creation of WebContents. Stores information
+ // about the newly created WebContents. This information is later used when
+ // the WebContents for the tab is added to the tabstrip and we receive the
+ // TAB_ADDED notification.
+ void RecordNewWebContents(content::WebContents* source_web_contents,
+ int source_render_process_id,
+ int source_render_frame_id,
+ GURL target_url,
+ content::WebContents* target_web_contents,
+ bool not_yet_in_tabstrip);
+
private:
// Used to cache the information about newly created WebContents objects.
struct PendingWebContents{
@@ -149,11 +159,6 @@ class WebNavigationEventRouter : public TabStripModelObserver,
const content::NotificationSource& source,
const content::NotificationDetails& details) override;
- // Handler for the NOTIFICATION_RETARGETING event. The method takes the
- // details of such an event and stores them for the later
- // NOTIFICATION_TAB_ADDED event.
- void Retargeting(const RetargetingDetails* details);
-
// Handler for the NOTIFICATION_TAB_ADDED event. The method takes the details
// of such an event and creates a JSON formated extension event from it.
void TabAdded(content::WebContents* tab);
@@ -209,6 +214,7 @@ class WebNavigationAPI : public BrowserContextKeyedAPI,
private:
friend class BrowserContextKeyedAPIFactory<WebNavigationAPI>;
+ friend class WebNavigationTabObserver;
content::BrowserContext* browser_context_;
@@ -216,6 +222,7 @@ class WebNavigationAPI : public BrowserContextKeyedAPI,
static const char* service_name() {
return "WebNavigationAPI";
}
+ static const bool kServiceRedirectedInIncognito = true;
static const bool kServiceIsNULLWhileTesting = true;
// Created lazily upon OnListenerAdded.
« no previous file with comments | « chrome/browser/chrome_notification_types.h ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698