Remove the retargeting notification

chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
@@ skipping 110 matching lines @@
   base::Closure quit_waiting_callback_;
   DownloadManager* manager_;
   std::vector<DownloadItem*> items_seen_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemCreatedObserver);
 };
 
 // Test class to help create SafeBrowsingNavigationObservers for each
 // WebContents before they are actually installed through AttachTabHelper.
 class TestNavigationObserverManager
-    : public SafeBrowsingNavigationObserverManager {
+    : public SafeBrowsingNavigationObserverManager,
+      public content::NotificationObserver {
  public:
   TestNavigationObserverManager() : SafeBrowsingNavigationObserverManager() {
     registrar_.Add(this, chrome::NOTIFICATION_TAB_ADDED,
                    content::NotificationService::AllSources());
   }
 
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override {
     if (type == chrome::NOTIFICATION_TAB_ADDED) {
       content::WebContents* dest_content =
           content::Details<content::WebContents>(details).ptr();
       DCHECK(dest_content);
       observer_list_.push_back(
           new SafeBrowsingNavigationObserver(dest_content, this));
       DCHECK(observer_list_.back());
-    } else if (type == chrome::NOTIFICATION_RETARGETING) {
-      RecordRetargeting(details);
     }
   }
 
  protected:
   ~TestNavigationObserverManager() override { observer_list_.clear(); }
 
  private:
   std::vector<SafeBrowsingNavigationObserver*> observer_list_;
+
+  content::NotificationRegistrar registrar_;
 };
 
 class SBNavigationObserverBrowserTest : public InProcessBrowserTest {
  public:
   SBNavigationObserverBrowserTest() {}
 
   void SetUpOnMainThread() override {
     // Disable Safe Browsing service since it is irrelevant to this test.
     browser()->profile()->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled,
                                                  false);
@@ skipping 407 matching lines @@
   ASSERT_TRUE(nav_list);
   ASSERT_EQ(3U, nav_list->Size());
   VerifyNavigationEvent(GURL(),       // source_url
                         GURL(),       // source_main_frame_url
                         initial_url,  // original_request_url
                         initial_url,  // destination_url
                         true,         // is_user_initiated,
                         true,         // has_committed
                         false,        // has_server_redirect
                         nav_list->Get(0));
   // The next NavigationEvent was obtained from NOIFICATION_RETARGETING.

[Jialiu Lin, 2017/03/02 00:36:52]

Change line 586 into
// The next NavigationEvent opens a new tab.

And remove comment line 587-590. Thanks!

[Patrick Noland, 2017/03/03 20:13:59]

Done.

   // TODO(jialiul): After https://crbug.com/651895 is fixed, we'll no longer
   // listen to NOTIFICATION_RETARGETING, hence only one NavigationEvent will
   // be observed with the true initator URL. This applies to other new tab
   // download, and target blank download test cases too.
   VerifyNavigationEvent(initial_url,   // source_url
                         initial_url,   // source_main_frame_url
                         download_url,  // original_request_url
                         download_url,  // destination_url
                         true,          // is_user_initiated,
                         false,         // has_committed
@@ skipping 118 matching lines @@
   ASSERT_TRUE(nav_list);
   ASSERT_EQ(4U, nav_list->Size());
   VerifyNavigationEvent(GURL(),       // source_url
                         GURL(),       // source_main_frame_url
                         initial_url,  // original_request_url
                         initial_url,  // destination_url
                         true,         // is_user_initiated,
                         true,         // has_committed
                         false,        // has_server_redirect
                         nav_list->Get(0));
   // TODO(jialiul): After https://crbug.com/651895 is fixed, we'll no longer

[Jialiu Lin, 2017/03/02 00:36:52]

Could you remove 725-727? thanks!

[Patrick Noland, 2017/03/03 20:13:59]

Done.

   // listen to NOTIFICATION_RETARGETING, hence only two NavigationEvents will
   // be observed with the true initator URL.
   VerifyNavigationEvent(initial_url,   // source_url
                         initial_url,   // source_main_frame_url
                         redirect_url,  // original_request_url
                         redirect_url,  // destination_url
                         true,          // is_user_initiated,
                         false,         // has_committed
                         false,         // has_server_redirect
                         nav_list->Get(1));
@@ skipping 1230 matching lines @@
                            GURL(),       // main_frame_url
                            ReferrerChainEntry::CLIENT_REDIRECT,  // type
                            test_server_ip,                       // ip_address
                            GURL(),                               // referrer_url
                            GURL(),               // referrer_main_frame_url
                            false,                // is_retargeting
                            std::vector<GURL>(),  // server redirects
                            referrer_chain.Get(0));
 }
 }  // namespace safe_browsing