chrome/browser/resources/settings/internet_page/internet_known_networks_page.js - Issue 2724413002: MD Settings: Internet: Show details for known networks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Issue 2724413002: MD Settings: Internet: Show details for known networks (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_known_networks_page.html ('k') | chrome/browser/resources/settings/internet_page/internet_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

index bf8b2b3f6f03ce4c4a9d41f5cab0844ac6b98f62..083a14a1d48c2ba25635704ba6c011ac2d529ca6 100644

--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

@@ -166,4 +166,17 @@ Polymer({

this.networkingPrivate.forgetNetwork(this.selectedGuid_);

/** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();

+ /**

+ * Fires a 'show-details' event with |this.networkState| as the details.

michaelpg 2017/03/04 01:11:25 did you mean something else by |this.networkState|

stevenjb 2017/03/06 18:38:30 Yep. Copy/pasted this and failed to update the com

+ * @param {Event} event

+ * @private

+ */

+ fireShowDetails_: function(event) {

+ var state =

+ /** @type {!{model: !{item: !CrOnc.NetworkStateProperties}}} */ (event)

+ .model.item;

+ this.fire('show-detail', state);

+ event.stopPropagation();

+ },

});