Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: net/nqe/event_creator.h

Issue 2724403004: NQE: Add net log event if the metric changes substantially (Closed)
Patch Set: ryansturm comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/nqe/event_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/event_creator.h
diff --git a/net/nqe/event_creator.h b/net/nqe/event_creator.h
index 5000195a96d73c1ad5d76a122234cfc786d6bf4a..4cd87e68a6cf72f4cd805a6f0634ec668f25799d 100644
--- a/net/nqe/event_creator.h
+++ b/net/nqe/event_creator.h
@@ -30,11 +30,11 @@ class NET_EXPORT_PRIVATE EventCreator {
~EventCreator();
// May add network quality changed event to the net-internals log if there
- // is a change in the effective connection type, or if there is a change in
- // the availability of HTTP RTT, transport RTT or bandwidth.
+ // is a change in the effective connection type, or if there is a meaningful
+ // change in the values of HTTP RTT, transport RTT or bandwidth.
// |effective_connection_type| is the current effective connection type.
// |network_quality| is the current network quality.
- void MaybeAddEffectiveConnectionTypeChangedEventToNetLog(
+ void MaybeAddNetworkQualityChangedEventToNetLog(
EffectiveConnectionType effective_connection_type,
const NetworkQuality& network_quality);
« no previous file with comments | « net/BUILD.gn ('k') | net/nqe/event_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698