Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: net/nqe/network_quality_estimator_unittest.cc

Issue 2724403004: NQE: Add net log event if the metric changes substantially (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/nqe/event_creator.cc ('K') | « net/nqe/network_quality_estimator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator_unittest.cc
diff --git a/net/nqe/network_quality_estimator_unittest.cc b/net/nqe/network_quality_estimator_unittest.cc
index 4c68ae0fcf5ab01687cdff639eead29c8dc87c4f..61b92e37477923bc7eeff305012c71a2f4df9725 100644
--- a/net/nqe/network_quality_estimator_unittest.cc
+++ b/net/nqe/network_quality_estimator_unittest.cc
@@ -411,7 +411,7 @@ TEST(NetworkQualityEstimatorTest, Caching) {
// |observer| should be notified as soon as it is added.
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1U, observer.effective_connection_types().size());
- EXPECT_EQ(
+ EXPECT_LE(
RyanSturm 2017/03/03 22:10:21 why is this LE now?
tbansal1 2017/03/03 23:06:35 With this CL, it is difficult to precisely determi
2, estimator.GetEntriesCount(NetLogEventType::NETWORK_QUALITY_CHANGED));
estimator.SimulateNetworkChange(
« net/nqe/event_creator.cc ('K') | « net/nqe/network_quality_estimator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698