Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2724363004: Content class factory and generalized text selector (Closed)
Patch Set: Interface cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
index 9b5936055b1ef659241700a224e1e81bd5d7349f..e4dcbde6cb7c9c7120a90aaaa0eda1a2ff395ecb 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
@@ -115,6 +115,8 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
// The client that implements Contextual Search functionality, or null if none exists.
private ContextualSearchClient mContextualSearchClient;
+ private ContextSelectionProvider mContextSelector;
+
/**
* Create {@link SelectionPopupController} instance.
* @param context Context for action mode.
@@ -145,6 +147,9 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
hideActionModeTemporarily(hideDuration);
}
};
+
+ // To be removed.
boliu 2017/03/06 16:56:13 should be a TODO comment then. And need to give re
Tima Vaisburd 2017/03/07 00:45:40 Just removed.
+ mContextSelector = ContentClassFactory.get().createContextSelectionProvider(null, window);
}
/**

Powered by Google App Engine
This is Rietveld 408576698