Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2724333002: Get rid of VisibleSelection::firstRangeOf() (Closed)
Patch Set: 2017-03-02T16:51:41 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index d73063fa545314227b75691fbe8b7ba98250a51a..299108f954c0146e100384dd8370919a51a7b2d6 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -2073,11 +2073,11 @@ const StaticRangeVector* targetRangesForInputEvent(const Node& node) {
if (!hasRichlyEditableStyle(node))
return nullptr;
return new StaticRangeVector(
- 1, StaticRange::create(
- firstRangeOf(node.document()
- .frame()
- ->selection()
- .computeVisibleSelectionInDOMTreeDeprecated())));
+ 1, StaticRange::create(createRange(firstEphemeralRangeOf(
+ node.document()
+ .frame()
+ ->selection()
+ .computeVisibleSelectionInDOMTreeDeprecated()))));
}
DispatchEventResult dispatchBeforeInputInsertText(Node* target,

Powered by Google App Engine
This is Rietveld 408576698