Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2724333002: Get rid of VisibleSelection::firstRangeOf() (Closed)
Patch Set: 2017-03-03T13:18:27 DCHECK(!range) => DCHECK(range) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 VisibleSelectionTemplate<EditingInFlatTreeStrategy>; 189 VisibleSelectionTemplate<EditingInFlatTreeStrategy>;
190 190
191 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&); 191 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&);
192 CORE_EXPORT VisibleSelectionInFlatTree 192 CORE_EXPORT VisibleSelectionInFlatTree
193 createVisibleSelection(const SelectionInFlatTree&); 193 createVisibleSelection(const SelectionInFlatTree&);
194 194
195 // We don't yet support multi-range selections, so we only ever have one range 195 // We don't yet support multi-range selections, so we only ever have one range
196 // to return. 196 // to return.
197 CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&); 197 CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&);
198 198
199 // TODO(sof): move more firstRangeOf() uses to be over EphemeralRange instead.
200 CORE_EXPORT Range* firstRangeOf(const VisibleSelection&);
201
202 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisibleSelection&); 199 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisibleSelection&);
203 CORE_EXPORT std::ostream& operator<<(std::ostream&, 200 CORE_EXPORT std::ostream& operator<<(std::ostream&,
204 const VisibleSelectionInFlatTree&); 201 const VisibleSelectionInFlatTree&);
205 202
206 } // namespace blink 203 } // namespace blink
207 204
208 #ifndef NDEBUG 205 #ifndef NDEBUG
209 // Outside the WebCore namespace for ease of invocation from gdb. 206 // Outside the WebCore namespace for ease of invocation from gdb.
210 void showTree(const blink::VisibleSelection&); 207 void showTree(const blink::VisibleSelection&);
211 void showTree(const blink::VisibleSelection*); 208 void showTree(const blink::VisibleSelection*);
212 void showTree(const blink::VisibleSelectionInFlatTree&); 209 void showTree(const blink::VisibleSelectionInFlatTree&);
213 void showTree(const blink::VisibleSelectionInFlatTree*); 210 void showTree(const blink::VisibleSelectionInFlatTree*);
214 #endif 211 #endif
215 212
216 #endif // VisibleSelection_h 213 #endif // VisibleSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698