Issue 272433002: Merge counters and v8-counters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272433002: Merge counters and v8-counters (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Merge counters and v8-counters BUG=none LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21185

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+469 lines, -501 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/counters.h	View	2 chunks	+397 lines, -0 lines	0 comments	Download
M	src/counters.cc	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/store-buffer.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
D	src/v8-counters.h	View	1 chunk	+0 lines, -412 lines	0 comments	Download
D	src/v8-counters.cc	View	1 chunk	+0 lines, -81 lines	0 comments	Download
M	src/zone-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/272433002/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): https://codereview.chromium.org/272433002/diff/1/src/store-buffer.cc#newcode10 src/store-buffer.cc:10: #include "v8.h" nit: The "v8.h" include file should ...

6 years, 7 months ago (2014-05-06 16:17:02 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-05-07 07:15:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21185 (presubmit successful).

Expand Messages | Collapse Messages