Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2724303004: Remove mojo download from dartium DEPS (Closed)

Created:
3 years, 9 months ago by Bill Hesse
Modified:
3 years, 9 months ago
Reviewers:
terry, kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove mojo download from dartium DEPS This step is causing failures on the buildbots, so if it isn't needed, we can remove it. The scripts try and use gsutil in an incorrect location, and we can no longer manually copy it because the buildbots have started automatically removing it. BUG=https://github.com/dart-lang/sdk/issues/28248 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/b226f6c3c2e7d46f9ada2c67712deb22eebe11ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M tools/deps/dartium.deps/DEPS.chromium View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
Terry, please test this to see if the dartium build still requires mojo shell download. ...
3 years, 9 months ago (2017-03-03 16:25:38 UTC) #2
kustermann
lgtm - it's worth a try
3 years, 9 months ago (2017-03-03 16:35:35 UTC) #3
Bill Hesse
3 years, 9 months ago (2017-03-06 08:32:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b226f6c3c2e7d46f9ada2c67712deb22eebe11ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698