Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/omnibox/browser/zero_suggest_provider.h

Issue 2724303002: Omnibox - Zero Suggest - Log When/Whether Contextual Search is Possible (Closed)
Patch Set: pkasting's comments, plus improve metrics description Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/zero_suggest_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/zero_suggest_provider.h
diff --git a/components/omnibox/browser/zero_suggest_provider.h b/components/omnibox/browser/zero_suggest_provider.h
index d4cf4165f8c8b97353ae5321d417ddcfd2cb35eb..b682e7b7ebeae82302f574d6d2c916e2b7a9d35a 100644
--- a/components/omnibox/browser/zero_suggest_provider.h
+++ b/components/omnibox/browser/zero_suggest_provider.h
@@ -122,6 +122,12 @@ class ZeroSuggestProvider : public BaseSearchProvider,
bool ShouldShowNonContextualZeroSuggest(const GURL& suggest_url,
const GURL& current_page_url) const;
+ // Returns a URL string that should be used to to request contextual
+ // suggestions from the default provider. Does not take into account whether
+ // sending this request is prohibited (e.g., in an incognito window). Returns
+ // an empty string in case of an error.
+ std::string GetContextualSuggestionsUrl() const;
+
// Checks whether we have a set of zero suggest results cached, and if so
// populates |matches_| with cached results.
void MaybeUseCachedSuggestions();
« no previous file with comments | « no previous file | components/omnibox/browser/zero_suggest_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698