Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2724243003: Revert of [ServiceWorker] Mojofy ActivateEvent of Service Worker (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index 3c027dfcc664ed692cbf9cdc85abd9a4b0b35966..edaeb0de56ce70ee521434ca8ad28ab14258fe1a 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -126,13 +126,6 @@
~MockServiceWorkerEventDispatcher() override {}
- void DispatchActivateEvent(
- const DispatchActivateEventCallback& callback) override {
- if (!helper_)
- return;
- helper_->OnActivateEventStub(callback);
- }
-
void DispatchFetchEvent(int fetch_event_id,
const ServiceWorkerFetchRequest& request,
mojom::FetchEventPreloadHandlePtr preload_handle,
@@ -326,6 +319,7 @@
bool handled = true;
current_embedded_worker_id_ = embedded_worker_id;
IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerTestHelper, message)
+ IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ActivateEvent, OnActivateEventStub)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEventStub)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -334,11 +328,11 @@
return handled;
}
-void EmbeddedWorkerTestHelper::OnActivateEvent(
- const mojom::ServiceWorkerEventDispatcher::DispatchActivateEventCallback&
- callback) {
- dispatched_events()->push_back(Event::Activate);
- callback.Run(SERVICE_WORKER_OK, base::Time::Now());
+void EmbeddedWorkerTestHelper::OnActivateEvent(int embedded_worker_id,
+ int request_id) {
+ SimulateSend(new ServiceWorkerHostMsg_ActivateEventFinished(
+ embedded_worker_id, request_id,
+ blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::OnExtendableMessageEvent(
@@ -525,12 +519,11 @@
AsWeakPtr(), thread_id, embedded_worker_id, message));
}
-void EmbeddedWorkerTestHelper::OnActivateEventStub(
- const mojom::ServiceWorkerEventDispatcher::DispatchActivateEventCallback&
- callback) {
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&EmbeddedWorkerTestHelper::OnActivateEvent,
- AsWeakPtr(), callback));
+void EmbeddedWorkerTestHelper::OnActivateEventStub(int request_id) {
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
+ FROM_HERE,
+ base::Bind(&EmbeddedWorkerTestHelper::OnActivateEvent, AsWeakPtr(),
+ current_embedded_worker_id_, request_id));
}
void EmbeddedWorkerTestHelper::OnExtendableMessageEventStub(

Powered by Google App Engine
This is Rietveld 408576698