Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: remoting/protocol/authenticator.h

Issue 2724223003: Disconnect all users if too many connection requests are received for It2Me (Closed)
Patch Set: Addressing CR Feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/it2me/it2me_host_unittest.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/authenticator.h
diff --git a/remoting/protocol/authenticator.h b/remoting/protocol/authenticator.h
index 93ecfd72a3129a01da4ff243f50ac9963b274cc9..1dee7471f3f14cb8a73e36538a69c0181417a568 100644
--- a/remoting/protocol/authenticator.h
+++ b/remoting/protocol/authenticator.h
@@ -53,7 +53,7 @@ class Authenticator {
// Next message is ready to be sent to the peer.
MESSAGE_READY,
- // Session is authenticated successufully.
+ // Session is authenticated successfully.
ACCEPTED,
// Session is rejected.
@@ -64,10 +64,20 @@ class Authenticator {
};
enum RejectionReason {
+ // The account credentials were not valid (i.e. incorrect PIN).
INVALID_CREDENTIALS,
+
+ // The client JID was not valid (i.e. violated a policy or was malformed).
INVALID_ACCOUNT,
+
+ // Generic error used when something goes wrong establishing a session.
PROTOCOL_ERROR,
+
+ // Session was rejected by the user (i.e. via the confirmation dialog).
REJECTED_BY_USER,
+
+ // Multiple, valid connection requests were received for the same session.
+ TOO_MANY_CONNECTIONS,
};
// Callback used for layered Authenticator implementations, particularly
@@ -134,7 +144,7 @@ class AuthenticatorFactory {
// authenticator for the new session. |first_message| specifies
// authentication part of the session-initiate stanza so that
// appropriate type of Authenticator can be chosen for the session
- // (useful when multiple authenticators is supported). Returns nullptr
+ // (useful when multiple authenticators are supported). Returns nullptr
// if the |first_message| is invalid and the session should be
// rejected. ProcessMessage() should be called with |first_message|
// for the result of this method.
« no previous file with comments | « remoting/host/it2me/it2me_host_unittest.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698