Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2724173002: Media Remoting: Add browser tests. (Closed)

Created:
3 years, 9 months ago by xjz
Modified:
3 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, apacible+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, erickung+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Remoting: Add browser tests. BUG=684065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+971 lines, -0 lines) Patch
A chrome/browser/extensions/api/media_remoting/media_remoting_browser_test.cc View 1 chunk +163 lines, -0 lines 0 comments Download
M chrome/browser/media/cast_remoting_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/bear.mp4 View Binary file 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/manifest.json View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/render_init_fail.html View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/render_init_fail.js View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/route_terminate.html View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/route_terminate.js View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/start_remoting.html View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/start_remoting.js View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/test_init.js View 1 chunk +65 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/test_media_router.js View 1 chunk +306 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/test_rpc.js View 1 chunk +267 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/toggle_renderer.html View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/media_remoting/toggle_renderer.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
xjz
PTAL
3 years, 9 months ago (2017-03-01 23:49:55 UTC) #2
miu
Nice work here! However, to avoid a bunch of extra work and merging, let's hold ...
3 years, 7 months ago (2017-05-02 22:15:01 UTC) #3
xjz
3 years, 7 months ago (2017-05-24 17:19:27 UTC) #4
On 2017/05/02 22:15:01, miu wrote:
> Nice work here! However, to avoid a bunch of extra work and merging, let's
hold
> on this just a little while longer: First, in the coming weeks, I'm going to
> re-do the extension APIs for Cast streaming to be "Mojo internal" based and
> better resolve remoting concepts (such as messaging, RTP streams for remoting,
> the shutdown race condition we found recently, etc.). I'll be getting rid of
the
> legacy extension APIs too. Many of the tests you wrote here should go with
that
> code.
> 
> Also, some of these tests seem to be Media Router specific. Does that mean
they
> have to run on special bots, or will they run on the normal Chromium bots?

Close this issue for now per the above comment.

Powered by Google App Engine
This is Rietveld 408576698