Issue 2724143002: Re-remove AstBuilder.accumulateIdentifierComponents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2724143002: Re-remove AstBuilder.accumulateIdentifierComponents. (Closed)

Created:
3 years, 9 months ago by Paul Berry

Modified:
3 years, 9 months ago

Reviewers:
Konstantin.Scheglov, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Re-remove AstBuilder.accumulateIdentifierComponents. This was removed in 3fbeb5d06428270e87bc82b8faacb6ab73a0b0e5 and accidentally re-introduced in 4500bb09203159a25eb7ff43296979344befb5c4 (presumably due to merge conflict resolution). Committed: https://github.com/dart-lang/sdk/commit/c6d1a0d3817159c98f35e5fdf8f386b027d486b7

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

3 years, 9 months ago (2017-03-01 23:30:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c6d1a0d3817159c98f35e5fdf8f386b027d486b7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages