third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc - Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

Issue 2724133003: [LayoutNG] Switch NGConstraintSpace to being RefCounted. (Closed)

Patch Set: moar. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h ('K') | « third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

index d4a1a118d6187b2c2e0ac9abf6ea35d9e93d9b80..b4cfa988cc5fc65aa46f8945a4a904e9b625a870 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc

@@ -64,10 +64,10 @@ TEST_F(NGOutOfFlowLayoutPartTest, FixedInsideAbs) {

// Test whether the oof fragments have been collected at NG->Legacy boundary.

Element* rel = document().getElementById("rel");

LayoutNGBlockFlow* block_flow = toLayoutNGBlockFlow(rel->layoutObject());

- NGConstraintSpace* space =

+ RefPtr<NGConstraintSpace> space =

NGConstraintSpace::CreateFromLayoutObject(*block_flow);

NGBlockNode* node = new NGBlockNode(block_flow);

- RefPtr<NGLayoutResult> result = node->Layout(space);

+ RefPtr<NGLayoutResult> result = node->Layout(space.get());

EXPECT_EQ(result->OutOfFlowDescendants().size(), (size_t)2);

// Test the final result.