third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing. (Closed)

Patch Set: Clean up after initial review. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 247d41b8d2ed7c8bd5f7a7da7f2b0150a73e79a3..213cca5c2e8a7199ccecc830c86b9c98125070bb 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -73,6 +73,8 @@ static bool updateContentClip(

static CompositorElementId createDomNodeBasedCompositorElementId(

const LayoutObject& object) {

+ // TODO(wkorman): Centralize this implementation with similar across

+ // animation, scrolling and compositing logic.

return createCompositorElementId(DOMNodeIds::idForNode(object.node()),

CompositorSubElementId::Primary);

}