third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing. (Closed)

Patch Set: Update expectations. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index b0358223377b6e01b16a659c4613618ac190492d..808334731e7d94e622661b774d428e1cedc4c56a 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -589,7 +589,8 @@ void PaintArtifactCompositor::collectPendingLayers(

void PaintArtifactCompositor::update(

const PaintArtifact& paintArtifact,

RasterInvalidationTrackingMap<const PaintChunk>* rasterChunkInvalidations,

- bool storeDebugInfo) {

+ bool storeDebugInfo,

+ CompositorElementIdSet& compositedElementIds) {

#ifndef NDEBUG

storeDebugInfo = true;

#endif

@@ -634,7 +635,12 @@ void PaintArtifactCompositor::update(

*pendingLayer.propertyTreeState.effect());

layer->set_offset_to_transform_parent(layerOffset);

- layer->SetElementId(pendingLayer.propertyTreeState.compositorElementId());

+ CompositorElementId elementId =

+ pendingLayer.propertyTreeState.compositorElementId();

+ if (elementId) {

+ layer->SetElementId(elementId);

+ compositedElementIds.insert(elementId);

+ }

m_rootLayer->AddChild(layer);

layer->set_property_tree_sequence_number(sPropertyTreeSequenceNumber);