Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h

Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing. (Closed)
Patch Set: Update expectations. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h
diff --git a/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h b/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h
index 22fd6c5b60782cd0a7bfc5ee675ebb560f4a902a..7722d47a168da7cc86e34efcb02350a91f4d8065 100644
--- a/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h
+++ b/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h
@@ -35,7 +35,9 @@
#include "core/animation/Animation.h"
#include "core/dom/TaskRunnerHelper.h"
#include "platform/Timer.h"
+#include "platform/graphics/CompositorElementId.h"
#include "platform/heap/Handle.h"
+#include "wtf/Optional.h"
#include "wtf/Vector.h"
namespace blink {
@@ -57,14 +59,17 @@ class CORE_EXPORT CompositorPendingAnimations final
void add(Animation*);
// Returns whether we are waiting for an animation to start and should
// service again on the next frame.
- bool update(bool startOnCompositor = true);
+ bool update(const Optional<CompositorElementIdSet>&,
+ bool startOnCompositor = true);
void notifyCompositorAnimationStarted(double monotonicAnimationStartTime,
int compositorGroup = 0);
DECLARE_TRACE();
private:
- void timerFired(TimerBase*) { update(false); }
+ void timerFired(TimerBase*) {
+ update(Optional<CompositorElementIdSet>(), false);
+ }
HeapVector<Member<Animation>> m_pending;
HeapVector<Member<Animation>> m_waitingForCompositorAnimationStart;

Powered by Google App Engine
This is Rietveld 408576698