third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 2724083002: [SPv2] Decomposite otherwise-compositable animations that paint nothing. (Closed)

Patch Set: Add unit tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js ('K') | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index 6d1f93cb3929f5fc1fb886b2e56d0111ea195f17..f91ed6624f176a013b88857c5e839daeacb8fdc4 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -69,6 +69,7 @@

#include "platform/graphics/paint/TransformDisplayItem.h"

#include "platform/instrumentation/tracing/TraceEvent.h"

#include "platform/json/JSONValues.h"

+#include "wtf/Optional.h"

namespace blink {

@@ -228,8 +229,10 @@ void PaintLayerCompositor::updateIfNeededRecursiveInternal() {

updateIfNeeded();

lifecycle().advanceTo(DocumentLifecycle::CompositingClean);

+ Optional<CompositorElementIdSet> compositedElementIds;

DocumentAnimations::updateAnimations(m_layoutView.document(),

- DocumentLifecycle::CompositingClean);

+ DocumentLifecycle::CompositingClean,

+ compositedElementIds);

m_layoutView.frameView()

->getScrollableArea()