Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/permissions/permission_manager.h

Issue 2723983004: Add PermissionManager::GetPermissionStatusForFrame function (Closed)
Patch Set: Add PermissionManager::GetPermissionStatusForFrame function Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_manager.h
diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h
index 033b56a7400c51dfcaa30fe3f35423ecdc3ae232..979b91e1a0d5bbf63230e621052ffcfd5a9e9f2c 100644
--- a/chrome/browser/permissions/permission_manager.h
+++ b/chrome/browser/permissions/permission_manager.h
@@ -55,6 +55,13 @@ class PermissionManager : public KeyedService,
const GURL& requesting_origin,
const GURL& embedding_origin);
+ // Returns the permission status for a given frame. This should be preferred
+ // over GetPermissionStatus as additional checks can be performed when we know
+ // the exact context the request is coming from.
+ PermissionResult GetPermissionStatusForFrame(
+ ContentSettingsType permission,
+ content::RenderFrameHost* render_frame_host);
+
// content::PermissionManager implementation.
int RequestPermission(
content::PermissionType permission,
@@ -119,6 +126,12 @@ class PermissionManager : public KeyedService,
ContentSettingsType content_type,
std::string resource_identifier) override;
+ PermissionResult GetPermissionStatusHelper(
+ ContentSettingsType permission,
+ content::RenderFrameHost* render_frame_host,
+ const GURL& requesting_origin,
+ const GURL& embedding_origin);
+
Profile* profile_;
PendingRequestsMap pending_requests_;
SubscriptionsMap subscriptions_;
« no previous file with comments | « chrome/browser/permissions/permission_context_base_unittest.cc ('k') | chrome/browser/permissions/permission_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698