Add PermissionManager::GetPermissionStatusForFrame function

chrome/browser/permissions/permission_manager.h

Index: chrome/browser/permissions/permission_manager.h
diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h
index 033b56a7400c51dfcaa30fe3f35423ecdc3ae232..979b91e1a0d5bbf63230e621052ffcfd5a9e9f2c 100644
--- a/chrome/browser/permissions/permission_manager.h
+++ b/chrome/browser/permissions/permission_manager.h
@@ -55,6 +55,13 @@ class PermissionManager : public KeyedService,
                                        const GURL& requesting_origin,
                                        const GURL& embedding_origin);
 
+  // Returns the permission status for a given frame. This should be preferred
+  // over GetPermissionStatus as additional checks can be performed when we know
+  // the exact context the request is coming from.
+  PermissionResult GetPermissionStatusForFrame(
+      ContentSettingsType permission,
+      content::RenderFrameHost* render_frame_host);
+
   // content::PermissionManager implementation.
   int RequestPermission(
       content::PermissionType permission,
@@ -119,6 +126,12 @@ class PermissionManager : public KeyedService,
                                ContentSettingsType content_type,
                                std::string resource_identifier) override;
 
+  PermissionResult GetPermissionStatusHelper(

[dominickn, 2017/03/02 06:54:33]

This is a little strangely named (I expect a Helper to be a class). Not really
sure what a better name here is though.

[benwells, 2017/03/02 07:33:05]

Maybe GetPermissonStatusInternal?

[raymes, 2017/03/07 02:31:15]

I'd like to avoid GetPermissonStatusInternal because we use it in a different
way in PermissionContextBase and I think having a different name will lead to
less confusion.

I think a helper function is a reasonably well understood term. For example it
looks like Bjarne Stroustrup uses the term in his books. If you think of a
better name though I'm happy to change it :)

+      ContentSettingsType permission,
+      content::RenderFrameHost* render_frame_host,
+      const GURL& requesting_origin,
+      const GURL& embedding_origin);
+
   Profile* profile_;
   PendingRequestsMap pending_requests_;
   SubscriptionsMap subscriptions_;