third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp - Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp b/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp

index b5562aa14fd454ea3191d1e0ed0cc0160b844e2b..73883e5a236c2dd731d543f085259167d8416e0c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp

@@ -83,7 +83,7 @@ V8DOMActivityLogger* V8DOMActivityLogger::currentActivityLogger() {

v8::HandleScope handleScope(isolate);

v8::Local<v8::Context> context = isolate->GetCurrentContext();

- if (context.IsEmpty() || !toDOMWindow(context))

+ if (context.IsEmpty() || !toLocalDOMWindow(context))

return 0;

V8PerContextData* contextData = ScriptState::from(context)->perContextData();

@@ -101,7 +101,7 @@ V8DOMActivityLogger::currentActivityLoggerIfIsolatedWorld() {

v8::HandleScope handleScope(isolate);

v8::Local<v8::Context> context = isolate->GetCurrentContext();

- if (context.IsEmpty() || !toDOMWindow(context))

+ if (context.IsEmpty() || !toLocalDOMWindow(context))

return 0;

ScriptState* scriptState = ScriptState::from(context);