third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp - Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

Issue 2723973002: Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

index 36196aced369e2f93da08350cb4de5c7bc4339f5..64a1b276db3494dde511034c07515d17e2a07551 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

@@ -31,8 +31,7 @@ void V8PerformanceObserver::constructorCustom(

v8::Local<v8::Object> wrapper = info.Holder();

Performance* performance = nullptr;

- LocalDOMWindow* window =

- toLocalDOMWindow(toDOMWindow(wrapper->CreationContext()));

+ LocalDOMWindow* window = toDOMWindow(wrapper->CreationContext());

if (!window) {

V8ThrowException::throwTypeError(

info.GetIsolate(),