Add AstBuilder support for fields.

Add AstBuilder support for fields.

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8decc11ac093ec8a67393167f0741df2824128be

[Paul Berry, 2017-03-01 00:53:35]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-03-01 01:03:04]

LGTM

[ahe, 2017-03-01 15:20:32]

lgtm


A single optional action item below, add a todo for me?

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1322: for (Token modifier
in modifiers) {
Would it make sense to have something more like
pkg/front_end/lib/src/fasta/modifier.dart?

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1325: // TODO(paulberry):
Check the order and uniqueness.
I think we should have the parser do that (while still recovering from wrong
order).

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1170: Link<Token> newModifiers =
removeOptCovariantTokenIfNotStatic(modifiers);
This is horrible. But that's not your fault. Would you mind adding a todo for me
to completely get rid of the method removeOptCovariantTokenIfNotStatic?

[Paul Berry, 2017-03-01 21:08:23]

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1322: for (Token modifier
in modifiers) {
On 2017/03/01 15:20:31, ahe wrote:
> Would it make sense to have something more like
> pkg/front_end/lib/src/fasta/modifier.dart?
> 

Unfortunately that wouldn't be quite enough; the analyzer AST needs to point to
the modifier tokens themselves.

However, I like the idea of encapsulating some of this logic in a class.  I'll
look into it.

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1325: // TODO(paulberry):
Check the order and uniqueness.
On 2017/03/01 15:20:31, ahe wrote:
> I think we should have the parser do that (while still recovering from wrong
> order).

Agreed.  There are several TODOs that say this, so I will submit a follow-up CL
to fix all of them.

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2723883002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1170: Link<Token> newModifiers =
removeOptCovariantTokenIfNotStatic(modifiers);
On 2017/03/01 15:20:31, ahe wrote:
> This is horrible. But that's not your fault. Would you mind adding a todo for
me
> to completely get rid of the method removeOptCovariantTokenIfNotStatic?

Done.

[Paul Berry, 2017-03-01 21:24:22]

Description was changed from

==========
Add AstBuilder support for fields.
==========

to

==========
Add AstBuilder support for fields.

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8decc11ac093ec8a67393167f0741df2824128be
==========

[Paul Berry, 2017-03-01 21:24:23]

Committed patchset #1 (id:1) manually as
8decc11ac093ec8a67393167f0741df2824128be (presubmit successful).