Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1798)

Unified Diff: content/renderer/media/render_media_client_unittest.cc

Issue 2723833002: WebM support for new multipart VP9 string. (Closed)
Patch Set: Put parsing behind a flag (--enable-hdr-output OR --enable-new-vp9-codec-string) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/render_media_client_unittest.cc
diff --git a/content/renderer/media/render_media_client_unittest.cc b/content/renderer/media/render_media_client_unittest.cc
index 21e3bb8d96c5749ac4fca7e21b3ec63ce081a67f..a7736027a4c157c6795b89568cfcc82d10327f93 100644
--- a/content/renderer/media/render_media_client_unittest.cc
+++ b/content/renderer/media/render_media_client_unittest.cc
@@ -181,4 +181,89 @@ TEST_F(RenderMediaClientTest, IsKeySystemsUpdateNeeded) {
#endif
}
+TEST_F(RenderMediaClientTest, IsSupportedVideoConfigBasics) {
+ // Default to common 709.
+ const gfx::ColorSpace::TransferID kTransferId =
+ gfx::ColorSpace::TransferID::BT709;
+
+ // Some codecs do not have a notion of level.
+ const int kUnspecifiedLevel = 0;
+
+ // Expect support for baseline configuration of known codecs.
+ EXPECT_TRUE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecH264, media::H264PROFILE_BASELINE, 1, kTransferId}));
+ EXPECT_TRUE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecVP8, media::VP8PROFILE_ANY, kUnspecifiedLevel,
+ kTransferId}));
+ EXPECT_TRUE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecVP9, media::VP9PROFILE_PROFILE0, kUnspecifiedLevel,
+ kTransferId}));
+ EXPECT_TRUE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecTheora, media::VIDEO_CODEC_PROFILE_UNKNOWN,
+ kUnspecifiedLevel, kTransferId}));
+
+ // Expect non-support for the following.
+ EXPECT_FALSE(render_media_client_->IsSupportedVideoConfig(
+ {media::kUnknownVideoCodec, media::VIDEO_CODEC_PROFILE_UNKNOWN,
+ kUnspecifiedLevel, kTransferId}));
+ EXPECT_FALSE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecVC1, media::VIDEO_CODEC_PROFILE_UNKNOWN, kUnspecifiedLevel,
+ kTransferId}));
+ EXPECT_FALSE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecMPEG2, media::VIDEO_CODEC_PROFILE_UNKNOWN,
+ kUnspecifiedLevel, kTransferId}));
+ EXPECT_FALSE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecMPEG4, media::VIDEO_CODEC_PROFILE_UNKNOWN,
+ kUnspecifiedLevel, kTransferId}));
+ EXPECT_FALSE(render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecHEVC, media::VIDEO_CODEC_PROFILE_UNKNOWN, kUnspecifiedLevel,
+ kTransferId}));
+}
+
+TEST_F(RenderMediaClientTest, IsSupportedVideoConfig_VP9TransferFunctions) {
+ const gfx::ColorSpace::TransferID kKnownTransfers[] = {
+ gfx::ColorSpace::TransferID::INVALID,
+ gfx::ColorSpace::TransferID::BT709,
+ gfx::ColorSpace::TransferID::GAMMA22,
+ gfx::ColorSpace::TransferID::GAMMA24,
+ gfx::ColorSpace::TransferID::GAMMA28,
+ gfx::ColorSpace::TransferID::SMPTE170M,
+ gfx::ColorSpace::TransferID::SMPTE240M,
+ gfx::ColorSpace::TransferID::LINEAR,
+ gfx::ColorSpace::TransferID::LOG,
+ gfx::ColorSpace::TransferID::LOG_SQRT,
+ gfx::ColorSpace::TransferID::IEC61966_2_4,
+ gfx::ColorSpace::TransferID::BT1361_ECG,
+ gfx::ColorSpace::TransferID::IEC61966_2_1,
+ gfx::ColorSpace::TransferID::BT2020_10,
+ gfx::ColorSpace::TransferID::BT2020_12,
+ gfx::ColorSpace::TransferID::SMPTEST2084,
+ gfx::ColorSpace::TransferID::SMPTEST428_1,
+ gfx::ColorSpace::TransferID::ARIB_STD_B67,
+ gfx::ColorSpace::TransferID::SMPTEST2084_NON_HDR,
+ gfx::ColorSpace::TransferID::LINEAR_HDR,
+ gfx::ColorSpace::TransferID::CUSTOM,
+ };
+ static_assert(arraysize(kKnownTransfers) - 1 ==
+ static_cast<size_t>(gfx::ColorSpace::TransferID::LAST),
+ "List known transfers is out of sync");
+
+ // TODO(hubbe): Verify support for HDR codecs when color management enabled.
+ const std::set<gfx::ColorSpace::TransferID> kSupportedTransfers = {
+ gfx::ColorSpace::TransferID::GAMMA22,
+ gfx::ColorSpace::TransferID::BT709,
+ gfx::ColorSpace::TransferID::SMPTE170M,
+ gfx::ColorSpace::TransferID::BT2020_10,
+ gfx::ColorSpace::TransferID::BT2020_12,
+ gfx::ColorSpace::TransferID::IEC61966_2_1,
+ };
+
+ // Verify supported transfers.
+ for (const auto transfer : kKnownTransfers) {
+ EXPECT_EQ(kSupportedTransfers.find(transfer) != kSupportedTransfers.end(),
+ render_media_client_->IsSupportedVideoConfig(
+ {media::kCodecVP9, media::VP9PROFILE_PROFILE0, 1, transfer}));
+ }
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698