Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2723833002: WebM support for new multipart VP9 string. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mime_util_internal.cc ('k') | media/base/video_codecs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index 226ef45acafe41a597c303d82a4d81342fa22772..336fc3e684eca6af491af8c6e5c88a9c5284e643 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -7,7 +7,10 @@
#include "base/macros.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
+#include "base/test/scoped_command_line.h"
#include "build/build_config.h"
+#include "media/base/media.h"
+#include "media/base/media_switches.h"
#include "media/base/mime_util.h"
#include "media/base/mime_util_internal.h"
#include "media/media_features.h"
@@ -219,6 +222,18 @@ TEST(MimeUtilTest, SplitCodecsToVector) {
EXPECT_EQ("mp4a.40.2", codecs_out[1]);
}
+// See deeper string parsing testing in video_codecs_unittests.cc.
+TEST(MimeUtilTest, ExperimentalMultiPartVp9) {
+ base::test::ScopedCommandLine scoped_command_line;
+
+ // Multi-part VP9 string not enabled by default.
+ EXPECT_FALSE(IsSupportedMediaFormat("video/webm", {"vp09.00.01.08"}));
+
+ // Should work if enabled.
+ EnableNewVp9CodecStringSupport();
+ EXPECT_TRUE(IsSupportedMediaFormat("video/webm", {"vp09.00.01.08"}));
+}
+
TEST(IsCodecSupportedOnAndroidTest, EncryptedCodecsFailWithoutPlatformSupport) {
// Vary all parameters except |has_platform_decoders|.
MimeUtil::PlatformInfo states_to_vary = VaryAllFields();
« no previous file with comments | « media/base/mime_util_internal.cc ('k') | media/base/video_codecs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698