chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java - Issue 2723803002: Fix two notification update issues on page navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 2723803002: Fix two notification update issues on page navigation (Closed)

Patch Set: fixed tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

index 80b942e6e3a83806566f04b8692da1e3a20c3697..e6a0c879ce4058cc3c6643169a6136702ab30e48 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

@@ -300,7 +300,6 @@ public class MediaSessionTabHelper implements MediaImageCallback {

+ "Using the full URL instead.");

}

- if (mOrigin != null && mOrigin.equals(origin)) return;

whywhat 2017/02/28 21:26:56 So what guarantees that the same URL navigation wo

Zhiqiang Zhang (Slow) 2017/02/28 22:13:10 It is called actually. See the last native browser

mOrigin = origin;

mFavicon = null;

mPageMediaImage = null;