Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 27238005: Add commandline flag for service workers. (Closed)

Created:
7 years, 2 months ago by alecflett
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, kinuko, michaeln
Visibility:
Public.

Description

Add commandline flag for service workers. this allows the browser to detect at runtime if service workers should be enabled or not. BUG=285976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alecflett
quick n easy - adding a flag to enable/disable ServiceWorkers so I can query that ...
7 years, 2 months ago (2013-10-14 22:01:16 UTC) #1
darin (slow to review)
LGTM, but I thought the idea was to brew the ServiceWorker within the renderer process ...
7 years, 2 months ago (2013-10-15 06:20:51 UTC) #2
alecflett
On 2013/10/15 06:20:51, darin wrote: > LGTM, but I thought the idea was to brew ...
7 years, 2 months ago (2013-10-15 15:49:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/27238005/1
7 years, 2 months ago (2013-10-15 15:49:40 UTC) #4
alecflett
(oops, adding michaeln and kinuko)
7 years, 2 months ago (2013-10-15 15:50:03 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 18:08:28 UTC) #6
Message was sent while issue was closed.
Change committed as 228721

Powered by Google App Engine
This is Rietveld 408576698