Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.h

Issue 2723793002: De-Element ScriptLoader (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLScriptElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLScriptElement.h b/third_party/WebKit/Source/core/html/HTMLScriptElement.h
index 223a8fd905a2f15d62b615d7614d643d419b4c7e..f9f4a3d78bfb1bb90c4754503bca9f4399d21fe8 100644
--- a/third_party/WebKit/Source/core/html/HTMLScriptElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLScriptElement.h
@@ -35,6 +35,7 @@ namespace blink {
class CORE_EXPORT HTMLScriptElement final : public HTMLElement,
public ScriptLoaderClient {
DEFINE_WRAPPERTYPEINFO();
+ USING_GARBAGE_COLLECTED_MIXIN(HTMLScriptElement);
public:
static HTMLScriptElement* create(Document&,
@@ -52,6 +53,9 @@ class CORE_EXPORT HTMLScriptElement final : public HTMLElement,
ScriptLoader* loader() const { return m_loader.get(); }
+ bool isScriptElement() const override { return true; }
+ Document& document() const override;
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -70,21 +74,33 @@ class CORE_EXPORT HTMLScriptElement final : public HTMLElement,
bool hasLegalLinkAttribute(const QualifiedName&) const override;
const QualifiedName& subResourceAttributeName() const override;
+ // ScriptLoaderClient overrides:
String sourceAttributeValue() const override;
String charsetAttributeValue() const override;
String typeAttributeValue() const override;
String languageAttributeValue() const override;
String forAttributeValue() const override;
String eventAttributeValue() const override;
+ String crossOriginAttributeValue() const override;
+ String integrityAttributeValue() const override;
+ String textFromChildren() override;
+ String textContent() const override;
bool asyncAttributeValue() const override;
bool deferAttributeValue() const override;
bool hasSourceAttribute() const override;
-
+ bool isConnected() const override;
+ bool hasChildren() const override;
+ bool isNonceableElement() const override;
+ bool allowInlineScriptForCSP(const AtomicString& nonce,
+ const WTF::OrdinalNumber&,
+ const String& scriptContent) override;
+ AtomicString initiatorName() const override;
void dispatchLoadEvent() override;
+ void dispatchErrorEvent() override;
+ void setScriptElementForBinding(
+ HTMLScriptElementOrSVGScriptElement&) override;
Element* cloneElementWithoutAttributesAndChildren() override;
-
- Member<ScriptLoader> m_loader;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698