Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2723793002: De-Element ScriptLoader (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 31b930a4fa63d6a4371252dd078706f1566a237f..b449ac535b3b03132fe18d794b166e047d25ed53 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -152,6 +152,7 @@ class ResourceFetcher;
class RootScrollerController;
class SVGDocumentExtensions;
class SVGUseElement;
+class ScriptLoaderClient;
class ScriptRunner;
class ScriptableDocumentParser;
class ScriptedAnimationController;
@@ -928,13 +929,9 @@ class CORE_EXPORT Document : public ContainerNode,
ScriptRunner* scriptRunner() { return m_scriptRunner.get(); }
- Element* currentScript() const {
- return !m_currentScriptStack.isEmpty() ? m_currentScriptStack.back().get()
- : nullptr;
- }
void currentScriptForBinding(HTMLScriptElementOrSVGScriptElement&) const;
- void pushCurrentScript(Element*);
- void popCurrentScript();
+ void pushCurrentScript(ScriptLoaderClient*);
+ void popCurrentScript(ScriptLoaderClient*);
void setTransformSource(std::unique_ptr<TransformSource>);
TransformSource* transformSource() const { return m_transformSource.get(); }
@@ -1023,7 +1020,6 @@ class CORE_EXPORT Document : public ContainerNode,
EventListener*,
const String& contextURL,
const WTF::OrdinalNumber& contextLine);
- bool allowExecutingScripts(Node*);
void enforceSandboxFlags(SandboxFlags mask) override;
@@ -1545,7 +1541,7 @@ class CORE_EXPORT Document : public ContainerNode,
Member<ScriptRunner> m_scriptRunner;
- HeapVector<Member<Element>> m_currentScriptStack;
+ HeapVector<Member<ScriptLoaderClient>> m_currentScriptStack;
std::unique_ptr<TransformSource> m_transformSource;

Powered by Google App Engine
This is Rietveld 408576698