De-Element ScriptLoader

third_party/WebKit/Source/core/frame/SubresourceIntegrity.h

Index: third_party/WebKit/Source/core/frame/SubresourceIntegrity.h
diff --git a/third_party/WebKit/Source/core/frame/SubresourceIntegrity.h b/third_party/WebKit/Source/core/frame/SubresourceIntegrity.h
index 56c6333e90a6a42d3a525ff551dd31b214f7be40..40523ea32054715dcb808054fde4e8217925ce88 100644
--- a/third_party/WebKit/Source/core/frame/SubresourceIntegrity.h
+++ b/third_party/WebKit/Source/core/frame/SubresourceIntegrity.h
@@ -14,7 +14,7 @@
 
 namespace blink {
 
-class Element;
+class Document;
 class ExecutionContext;
 class KURL;
 class Resource;
@@ -31,13 +31,14 @@ class CORE_EXPORT SubresourceIntegrity {
   // The versions with the IntegrityMetadataSet passed as the first argument
   // assume that the integrity attribute has already been parsed, and the
   // IntegrityMetadataSet represents the result of that parsing.
-  static bool CheckSubresourceIntegrity(const Element&,
+  static bool CheckSubresourceIntegrity(const String& attribute,

[hiroshige, 2017/03/01 00:58:14]

Naming e.g. |integrityAttribute| is better to explicitly states
that this is "integrity" attribute.

An alternative might be to use ScriptLoaderClient here, but optional.

[Nate Chapin, 2017/03/01 21:34:59]

Renamed to |integrityAttribute|.

ScriptLoaderClient won't work, as this is also called by LinkStyle.

+                                        Document&,

[hiroshige, 2017/03/01 00:58:14]

+A comment that this Document is <script>'s document().
(Other parameters also lack comments though...)

[Nate Chapin, 2017/03/01 21:34:59]

Done.

[Nate Chapin, 2017/03/01 21:34:59]

Slightly more generic comment added, as this can be called for non-<script>

                                         const char* content,
                                         size_t,
                                         const KURL& resourceUrl,
                                         const Resource&);
   static bool CheckSubresourceIntegrity(const IntegrityMetadataSet&,
-                                        const Element&,
+                                        Document&,
                                         const char* content,
                                         size_t,
                                         const KURL& resourceUrl,