Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2723793002: De-Element ScriptLoader (Closed)
Patch Set: ScriptLoaderClient->ScriptElementBase, pure virtual interface, add fixme Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/BUILD.gn ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 2a5f7b490cdb9622aaa1c6348342294d5f006ba6..c5988ebcc9c95cb58dcfc0abc861f65984ccd0cf 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -150,6 +150,7 @@ class ResourceFetcher;
class RootScrollerController;
class SVGDocumentExtensions;
class SVGUseElement;
+class ScriptElementBase;
class ScriptRunner;
class ScriptableDocumentParser;
class ScriptedAnimationController;
@@ -920,13 +921,9 @@ class CORE_EXPORT Document : public ContainerNode,
ScriptRunner* scriptRunner() { return m_scriptRunner.get(); }
- Element* currentScript() const {
- return !m_currentScriptStack.isEmpty() ? m_currentScriptStack.back().get()
- : nullptr;
- }
void currentScriptForBinding(HTMLScriptElementOrSVGScriptElement&) const;
- void pushCurrentScript(Element*);
- void popCurrentScript();
+ void pushCurrentScript(ScriptElementBase*);
+ void popCurrentScript(ScriptElementBase*);
void setTransformSource(std::unique_ptr<TransformSource>);
TransformSource* transformSource() const { return m_transformSource.get(); }
@@ -1015,7 +1012,6 @@ class CORE_EXPORT Document : public ContainerNode,
EventListener*,
const String& contextURL,
const WTF::OrdinalNumber& contextLine);
- bool allowExecutingScripts(Node*);
void enforceSandboxFlags(SandboxFlags mask) override;
@@ -1536,7 +1532,7 @@ class CORE_EXPORT Document : public ContainerNode,
Member<ScriptRunner> m_scriptRunner;
- HeapVector<Member<Element>> m_currentScriptStack;
+ HeapVector<Member<ScriptElementBase>> m_currentScriptStack;
std::unique_ptr<TransformSource> m_transformSource;
« no previous file with comments | « third_party/WebKit/Source/core/dom/BUILD.gn ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698