DevTools: restore array lengths for long arrays

third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 ObjectUI.RemoteObjectPreviewFormatter = class {
   /**
    * @param {!Protocol.Runtime.PropertyPreview} a
    * @param {!Protocol.Runtime.PropertyPreview} b
@@ skipping 14 matching lines @@
    */
   appendObjectPreview(parentElement, preview, isEntry) {
     const previewExperimentEnabled = Runtime.experiments.isEnabled('objectPreviews');
     var description = preview.description;
     if (preview.type !== 'object' || preview.subtype === 'null' || (previewExperimentEnabled && isEntry)) {
       parentElement.appendChild(this.renderPropertyPreview(preview.type, preview.subtype, description));
       return;
     }
     const isArrayOrTypedArray = preview.subtype === 'array' || preview.subtype === 'typedarray';
     if (description) {
-      if (previewExperimentEnabled) {
-        // Hide the description for plain objects and plain arrays.
-        const plainObjectDescription = 'Object';
-        const size = SDK.RemoteObject.arrayLength(preview) || SDK.RemoteObject.mapOrSetEntriesCount(preview);
-        var text = preview.subtype === 'typedarray' ? SDK.RemoteObject.arrayNameFromDescription(description) : '';
-        if (isArrayOrTypedArray)
-          text += size > 1 ? ('(' + size + ')') : '';
-        else
-          text = description === plainObjectDescription ? '' : description;
-        if (text.length > 0)
-          parentElement.createChild('span', 'object-description').textContent = text + ' ';
-      } else if (preview.subtype !== 'array') {
-        parentElement.createTextChildren(description, ' ');
+      const size = SDK.RemoteObject.arrayLength(preview) || SDK.RemoteObject.mapOrSetEntriesCount(preview);

[lushnikov, 2017/02/28 22:21:08]

value of mapOrSetEntriesCount is never used

the value of arrayLength could be computed only inside the
if(isArrayOrTypedArray).. condition

[luoe, 2017/02/28 22:32:57]

Done.

+      var text = preview.subtype === 'typedarray' ? SDK.RemoteObject.arrayNameFromDescription(description) : '';

[lushnikov, 2017/02/28 22:21:08]

this should go under isArrayOrTypedArray as well

[luoe, 2017/02/28 22:32:57]

Done.

+      if (isArrayOrTypedArray) {
+        text += size > 1 ? ('(' + size + ')') : '';
+      } else {
+        var hideObjectKeyword = previewExperimentEnabled && description === 'Object';

[lushnikov, 2017/02/28 22:21:08]

hideDescription?

[luoe, 2017/02/28 22:32:57]

Done.

+        text = hideObjectKeyword ? '' : description;
       }
+      if (text.length > 0)
+        parentElement.createChild('span', 'object-description').textContent = text + ' ';
     }
 
     parentElement.createTextChild(isArrayOrTypedArray ? '[' : '{');
     if (preview.entries)
       this._appendEntriesPreview(parentElement, preview);
     else if (isArrayOrTypedArray)
       this._appendArrayPropertiesPreview(parentElement, preview);
     else
       this._appendObjectPropertiesPreview(parentElement, preview);
     if (preview.overflow)
@@ skipping 182 matching lines @@
     if (type === 'object' && !subtype) {
       span.textContent = this._abbreviateFullQualifiedClassName(description);
       span.title = description;
       return span;
     }
 
     span.textContent = description;
     return span;
   }
 };