Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

Issue 2723663002: Refactor DocumentMarkerController (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp
index d6c47b12d4b49ab440c5f56edb817165f971a6ab..f9fc29dfe8b6fe2da0a00f8a2b445ccdd9b599ab 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp
@@ -142,7 +142,9 @@ DocumentMarker::DocumentMarker(MarkerType type,
m_endOffset(endOffset),
m_details(description.isEmpty()
? nullptr
- : DocumentMarkerDescription::create(description)) {}
+ : DocumentMarkerDescription::create(description)) {
+ DCHECK(type != DocumentMarker::TextMatch);
+}
DocumentMarker::DocumentMarker(unsigned startOffset,
unsigned endOffset,
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.h ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698