Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2723663002: Refactor DocumentMarkerController (Closed)
Patch Set: Use correct base commit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/editing/markers/RenderedTextMatchMarker.h ('K') | « third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 4959e65cffdd86d3499cbe53c908e02024163cdf..86523ecf7cd096910c898a69adb485f42e650dbe 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2596,11 +2596,12 @@ void FrameView::invalidatePaintForTickmarks() {
}
void FrameView::getTickmarks(Vector<IntRect>& tickmarks) const {
- if (!m_tickmarks.isEmpty())
+ if (!m_tickmarks.isEmpty()) {
Xiaocheng 2017/03/21 03:59:44 This change is irrelevant.
tickmarks = m_tickmarks;
- else
+ } else {
tickmarks = frame().document()->markers().renderedRectsForMarkers(
DocumentMarker::TextMatch);
+ }
}
void FrameView::setInputEventsTransformForEmulation(const IntSize& offset,
« third_party/WebKit/Source/core/editing/markers/RenderedTextMatchMarker.h ('K') | « third_party/WebKit/Source/core/editing/markers/TextMatchMarkerList.cpp ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698