Refactor DocumentMarkerController

third_party/WebKit/Source/core/editing/markers/EditingMarkerListThatMergesTouchingMarkers.h

Index: third_party/WebKit/Source/core/editing/markers/EditingMarkerListThatMergesTouchingMarkers.h
diff --git a/third_party/WebKit/Source/core/editing/markers/EditingMarkerListThatMergesTouchingMarkers.h b/third_party/WebKit/Source/core/editing/markers/EditingMarkerListThatMergesTouchingMarkers.h
new file mode 100644
index 0000000000000000000000000000000000000000..3ac379b1359063375072682cb34d94a77f5030c3
--- /dev/null
+++ b/third_party/WebKit/Source/core/editing/markers/EditingMarkerListThatMergesTouchingMarkers.h
@@ -0,0 +1,24 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EditingMarkerListThatMergesTouchingMarkers_h
+#define EditingMarkerListThatMergesTouchingMarkers_h
+
+#include "core/editing/markers/EditingMarkerList.h"
+
+namespace blink {
+
+class EditingMarkerListThatMergesTouchingMarkers : public EditingMarkerList {

[Xiaocheng, 2017/03/21 19:12:11]

The two subclasses of this class basically share the same behavior. I don't see
any need for them to have very different behaviors, either.

So how about merging them into the same class:

class SpellCheckMarkerList final : public EditingMarkerList {
 public:
  explicit SpellCheckMarkerList(DMC*, DM::MarkerType);
  DM::MarkerType allowedMarkerType() const final; // returns m_type;
  void insert(DM*) final;
  void removeMarkersForWords(...);
 private:
  DM::MarkerType m_type;
}

+  WTF_MAKE_NONCOPYABLE(EditingMarkerListThatMergesTouchingMarkers);
+
+ public:
+  explicit EditingMarkerListThatMergesTouchingMarkers(
+      DocumentMarkerController*);
+
+  void insert(DocumentMarker*) final;
+};
+
+}  // namespace blink
+
+#endif  // EditingMarkerListThatMergesTouchingMarkers_h