Refactor DocumentMarkerController

third_party/WebKit/Source/core/editing/markers/SpellingMarkerList.cpp

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/editing/markers/SpellingMarkerList.h"
+
+#include <utility>
+#include "core/dom/Text.h"
+
+namespace blink {
+
+SpellingMarkerList::SpellingMarkerList(
+    DocumentMarkerController* documentMarkerController)
+    : EditingMarkerListThatMergesTouchingMarkers(documentMarkerController) {}
+
+DocumentMarker::MarkerType SpellingMarkerList::allowedMarkerType() const {
+  return DocumentMarker::Spelling;
+}
+
+void SpellingMarkerList::removeMarkersForWords(const Text& textNode,
+                                               const Vector<String>& words) {
+  // Build a second vector and swap with m_markers to avoid O(n^2) performance

[Xiaocheng, 2017/03/01 22:24:48]

Nice!

+  HeapVector<Member<DocumentMarker>> newMarkerList;
+
+  for (Member<DocumentMarker> marker : m_markers) {
+    unsigned start = marker->startOffset();
+    unsigned length = marker->endOffset() - marker->startOffset();
+
+    String markerText = textNode.data().substring(start, length);
+    if (!words.contains(markerText))
+      newMarkerList.push_back(marker);
+  }
+
+  std::swap(m_markers, newMarkerList);
+}
+
+}  // namespace blink