Refactor DocumentMarkerController

third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

 /*
  * This file is part of the DOM implementation for WebCore.
  *
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 14 matching lines @@
 
 #include "core/CoreExport.h"
 #include "platform/graphics/Color.h"
 #include "platform/heap/Handle.h"
 #include "wtf/VectorTraits.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class DocumentMarkerDetails;
+class RenderedTextMatchMarker;
 
 // A range of a node within a document that is "marked", such as the range of a
 // misspelled word. It optionally includes a description that could be displayed
 // in the user interface. It also optionally includes a flag specifying whether
 // the match is active, which is ignored for all types other than type
 // TextMatch.
 class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
  public:
   enum MarkerTypeIndex {
     SpellingMarkerIndex = 0,
@@ skipping 66 matching lines @@
   const String& description() const;
   bool activeMatch() const;
   Color underlineColor() const;
   bool thick() const;
   Color backgroundColor() const;
   DocumentMarkerDetails* details() const;
 
   void setActiveMatch(bool);
   void clearDetails() { m_details.clear(); }
 
-  // Offset modifications are done by DocumentMarkerController.
-  // Other classes should not call following setters.
+  // Offset modifications are done by DocumentMarkerController and the classes
+  // that implement the marker lists. Other classes should not call following
+  // setters.
   void setStartOffset(unsigned offset) { m_startOffset = offset; }
   void setEndOffset(unsigned offset) { m_endOffset = offset; }
   void shiftOffsets(int delta);
 
+  virtual bool isRenderedTextMatch() const;
+
+  RenderedTextMatchMarker* asRenderedTextMatchMarker();

[Xiaocheng, 2017/03/01 22:24:48]

Please use the DEFINE_TYPE_CASTS macro to define type casts.

Example:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/c...

+
   bool operator==(const DocumentMarker& o) const {
     return type() == o.type() && startOffset() == o.startOffset() &&
            endOffset() == o.endOffset();
   }
 
   bool operator!=(const DocumentMarker& o) const { return !(*this == o); }
 
   DECLARE_TRACE();
 
  private:
@@ skipping 17 matching lines @@
   virtual bool isDescription() const { return false; }
   virtual bool isTextMatch() const { return false; }
   virtual bool isComposition() const { return false; }
 
   DEFINE_INLINE_VIRTUAL_TRACE() {}
 };
 
 }  // namespace blink
 
 #endif  // DocumentMarker_h