Issue 2723643002: Properly handle instantiator when allocating or cloning closure instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2723643002: Properly handle instantiator when allocating or cloning closure instance. (Closed)

Created:
3 years, 9 months ago by regis

Modified:
3 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Properly handle instantiator when allocating or cloning closure instance. This should fix the vm-kernel bots. Committed: https://github.com/dart-lang/sdk/commit/269aaf03054d4e3fcd722a2b4912130e70ad0f79

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -19 lines)			Patch
M	runtime/lib/function.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	4 chunks	+13 lines, -11 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

regis

Committed patchset #1 (id:1) manually as 269aaf03054d4e3fcd722a2b4912130e70ad0f79 (presubmit successful).

3 years, 9 months ago (2017-02-27 22:51:38 UTC) #4

Message was sent while issue was closed.

lgtm