Issue 272363002: Re-land reverted r269593; it was a red herring for ash_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272363002: Re-land reverted r269593; it was a red herring for ash_unittests (Closed)

Created:
6 years, 7 months ago by mdempsky

Modified:
6 years, 7 months ago

Reviewers:
varkha, sadrul

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-land reverted r269593; it was a red herring for ash_unittests Avoids releasing capture in EndMoveLoop if capture was switched to another window while dragging. This variant relies on checking if a drag input window still has capture before releasing the grab. A better alternative is in CL https://codereview.chromium.org/262893002/. TBR=sadrul@chromium.org BUG=363503 TEST=Follow the exact steps in the bug description. TEST=interactive_ui_tests --gtest_filter=*TabDragging* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269688

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc	View		4 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/272363002/1

6 years, 7 months ago (2014-05-10 21:17:50 UTC) #4

Message was sent while issue was closed.

Change committed as 269688

Expand Messages | Collapse Messages