Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4206)

Unified Diff: chrome/test/data/webui/extensions/extension_detail_view_test.js

Issue 2723613004: [MD Extensions] Update Detail View UI (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extensions_ui.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/extensions/extension_detail_view_test.js
diff --git a/chrome/test/data/webui/extensions/extension_detail_view_test.js b/chrome/test/data/webui/extensions/extension_detail_view_test.js
index 7572b4621cf3b9d148d16b6012106a2061bff0e3..d41f22599baea7a6b8b02382cffa5e4269fc52aa 100644
--- a/chrome/test/data/webui/extensions/extension_detail_view_test.js
+++ b/chrome/test/data/webui/extensions/extension_detail_view_test.js
@@ -44,6 +44,7 @@ cr.define('extension_detail_view_tests', function() {
item = new extensions.DetailView();
item.set('data', extensionData);
item.set('delegate', mockDelegate);
+ item.set('inDevMode', false);
document.body.appendChild(item);
});
@@ -54,8 +55,9 @@ cr.define('extension_detail_view_tests', function() {
var testIsVisible = extension_test_util.isVisible.bind(null, item);
expectTrue(testIsVisible('#close-button'));
- expectFalse(testIsVisible('#open-homepage'));
- expectFalse(testIsVisible('#options'));
+ expectTrue(testIsVisible('#icon'));
+ expectTrue(testIsVisible('#enable-toggle'));
+ expectFalse(testIsVisible('#extensions-options'));
// Check the checkboxes visibility and state. They should be visible
// only if the associated option is enabled, and checked if the
@@ -107,12 +109,18 @@ cr.define('extension_detail_view_tests', function() {
var optionsUrl =
'chrome-extension://' + extensionData.id + '/options.html';
item.set('data.optionsPage', {openInTab: true, url: optionsUrl});
- expectTrue(testIsVisible('#options'));
+ expectTrue(testIsVisible('#extensions-options'));
- var homepageUrl = 'https://www.example.com/';
- item.set('data.homePage', {specified: true, url: homepageUrl});
- expectTrue(testIsVisible('#open-homepage'));
- expectEquals(homepageUrl, item.$$('#open-homepage').href);
+ // TODO(devlin): Add checks for homepage once it's added back to the
+ // mocks.
+
+ expectFalse(testIsVisible('#id-section'));
+ expectFalse(testIsVisible('#inspectable-views'));
+
+ item.set('inDevMode', true);
+ Polymer.dom.flush();
+ expectTrue(testIsVisible('#id-section'));
+ expectTrue(testIsVisible('#inspectable-views'));
});
test(assert(TestNames.ClickableElements), function() {
@@ -133,7 +141,11 @@ cr.define('extension_detail_view_tests', function() {
item.$$('#collect-errors'), 'setItemCollectsErrors',
[extensionData.id, true]);
mockDelegate.testClickingCalls(
- item.$$('#options'), 'showItemOptionsPage', [extensionData.id]);
+ item.$$('#extensions-options'), 'showItemOptionsPage',
+ [extensionData.id]);
+ mockDelegate.testClickingCalls(
+ item.$$('#remove-extension'), 'deleteItem',
+ [extensionData.id]);
});
});
}
« no previous file with comments | « chrome/browser/ui/webui/extensions/extensions_ui.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698