[MD Extensions] Update Detail View UI

chrome/browser/resources/md_extensions/item.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   /** @interface */
   var ItemDelegate = function() {};
 
   ItemDelegate.prototype = {
     /** @param {string} id */
@@ skipping 139 matching lines @@
     onReloadTap_: function() {
       this.delegate.reloadItem(this.data.id);
     },
 
     /** @private */
     onRepairTap_: function() {
       this.delegate.repairItem(this.data.id);
     },
 
     /**
-     * Returns true if the extension is enabled, including terminated
-     * extensions.
      * @return {boolean}
      * @private
      */
-    isEnabled_: function() {
-      switch (this.data.state) {
-        case chrome.developerPrivate.ExtensionState.ENABLED:
-        case chrome.developerPrivate.ExtensionState.TERMINATED:
-          return true;
-        case chrome.developerPrivate.ExtensionState.DISABLED:
-          return false;
-      }
-      assertNotReached();  // FileNotFound.
+    isEnabled_: function() { return extensions.isEnabled(this.data.state); },
+
+    /**
+     * @return {boolean}
+     * @private
+     */
+    isEnableToggleEnabled_: function() {
+      return extensions.userCanChangeEnablement(this.data);
     },
 
     /**
      * Returns true if the enable toggle should be shown.
      * @return {boolean}
      * @private
      */
     showEnableToggle_: function() {
       return !this.isTerminated_() && !this.data.disableReasons.corruptInstall;
     },
@@ skipping 53 matching lines @@
      */
     computeInspectViewsHidden_: function() {
       return !this.data.views || this.data.views.length == 0;
     },
 
     /**
      * @return {string}
      * @private
      */
     computeFirstInspectLabel_: function() {
-      var view = this.data.views[0];
-      // Trim the "chrome-extension://<id>/".
-      var url = new URL(view.url);
-      var label = view.url;
-      if (url.protocol == 'chrome-extension:')
-        label = url.pathname.substring(1);
-      if (label == '_generated_background_page.html')
-        label = this.i18n('viewBackgroundPage');
-      // Add any qualifiers.
-      label += (view.incognito ? ' ' + this.i18n('viewIncognito') : '') +
-               (view.renderProcessId == -1 ?
-                    ' ' + this.i18n('viewInactive') : '') +
-               (view.isIframe ? ' ' + this.i18n('viewIframe') : '');
-      var index = this.data.views.indexOf(view);
-      assert(index >= 0);
-      if (index < this.data.views.length - 1)
+      // Note: theoretically, this wouldn't be called without any inspectable
+      // views (because it's in a dom-if="!computeInspectViewsHidden_()").
+      // However, due to the recycling behavior of iron list, it seems that
+      // sometimes it can. Even when it is, the UI behaves properly, but we
+      // need to handle the case gracefully.
+      if (this.data.views.length == 0)
+        return '';
+      var label = extensions.computeInspectableViewLabel(this.data.views[0]);
+      if (this.data.views.length > 1)
         label += ',';
       return label;
     },
 
     /**
      * @return {boolean}
      * @private
      */
     computeExtraViewsHidden_: function() {
       return this.data.views.length <= 1;
@@ skipping 26 matching lines @@
       return this.data.blacklistText ? 'severe' : 'mild';
     },
   });
 
   return {
     Item: Item,
     ItemDelegate: ItemDelegate,
   };
 });