[MD Extensions] Update Detail View UI

chrome/test/data/webui/extensions/extension_detail_view_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for extensions-detail-view. */
 cr.define('extension_detail_view_tests', function() {
   /** @enum {string} */
   var TestNames = {
     Layout: 'layout',
     ClickableElements: 'clickable elements',
@@ skipping 26 matching lines @@
         extensionData = extension_test_util.createExtensionInfo({
           incognitoAccess: {isEnabled: true, isActive: false},
           fileAccess: {isEnabled: true, isActive: false},
           runOnAllUrls: {isEnabled: true, isActive: false},
           errorCollection: {isEnabled: true, isActive: false},
         });
         mockDelegate = new extension_test_util.MockItemDelegate();
         item = new extensions.DetailView();
         item.set('data', extensionData);
         item.set('delegate', mockDelegate);
+        item.set('inDevMode', false);
         document.body.appendChild(item);
       });
 
       test(assert(TestNames.Layout), function() {
         Polymer.dom.flush();
 
         extension_test_util.testIronIcons(item);
 
         var testIsVisible = extension_test_util.isVisible.bind(null, item);
         expectTrue(testIsVisible('#close-button'));
-        expectFalse(testIsVisible('#open-homepage'));
-        expectFalse(testIsVisible('#options'));
+        expectTrue(testIsVisible('#icon'));
+        expectTrue(testIsVisible('#enable-toggle'));
+        expectFalse(testIsVisible('#extensions-options'));
 
         // Check the checkboxes visibility and state. They should be visible
         // only if the associated option is enabled, and checked if the
         // associated option is active.
         var accessOptions = [
           {key: 'incognitoAccess', id: '#allow-incognito'},
           {key: 'fileAccess', id: '#allow-on-file-urls'},
           {key: 'runOnAllUrls', id: '#allow-on-all-sites'},
           {key: 'errorCollection', id: '#collect-errors'},
         ];
@@ skipping 31 matching lines @@
         Polymer.dom.flush();
         expectTrue(testIsVisible('#permissions-list'));
         expectEquals(2,
                      item.$$('#permissions-list').querySelectorAll('li').
                          length);
         expectFalse(testIsVisible('#no-permissions'));
 
         var optionsUrl =
              'chrome-extension://' + extensionData.id + '/options.html';
         item.set('data.optionsPage', {openInTab: true, url: optionsUrl});
-        expectTrue(testIsVisible('#options'));
+        expectTrue(testIsVisible('#extensions-options'));
 
-        var homepageUrl = 'https://www.example.com/';
-        item.set('data.homePage', {specified: true, url: homepageUrl});
-        expectTrue(testIsVisible('#open-homepage'));
-        expectEquals(homepageUrl, item.$$('#open-homepage').href);
+        // TODO(devlin): Add these back once homepages are in the mocks again.

[michaelpg, 2017/03/06 19:08:46]

I would leave a TODO remove the unused code. Yay version control!

[michaelpg, 2017/03/06 19:55:02]

That is, leave this TODO, *but* remove commented-out code.

[Devlin, 2017/03/06 20:12:12]

Okay, done.

+        // expectFalse(testIsVisible('#open-homepage'));
+        // var homepageUrl = 'https://www.example.com/';
+        // item.set('data.homePage', {specified: true, url: homepageUrl});
+        // expectTrue(testIsVisible('#open-homepage'));
+        // expectEquals(homepageUrl, item.$$('#open-homepage').href);
+
+        expectFalse(testIsVisible('#id-section'));
+        expectFalse(testIsVisible('#inspectable-views'));
+
+        item.set('inDevMode', true);
+        Polymer.dom.flush();
+        expectTrue(testIsVisible('#id-section'));
+        expectTrue(testIsVisible('#inspectable-views'));
       });
 
       test(assert(TestNames.ClickableElements), function() {
         var optionsUrl =
             'chrome-extension://' + extensionData.id + '/options.html';
         item.set('data.optionsPage', {openInTab: true, url: optionsUrl});
         Polymer.dom.flush();
         mockDelegate.testClickingCalls(
             item.$$('#allow-incognito'), 'setItemAllowedIncognito',
             [extensionData.id, true]);
         mockDelegate.testClickingCalls(
             item.$$('#allow-on-file-urls'), 'setItemAllowedOnFileUrls',
             [extensionData.id, true]);
         mockDelegate.testClickingCalls(
             item.$$('#allow-on-all-sites'), 'setItemAllowedOnAllSites',
             [extensionData.id, true]);
         mockDelegate.testClickingCalls(
             item.$$('#collect-errors'), 'setItemCollectsErrors',
             [extensionData.id, true]);
         mockDelegate.testClickingCalls(
-            item.$$('#options'), 'showItemOptionsPage', [extensionData.id]);
+            item.$$('#extensions-options'), 'showItemOptionsPage',
+            [extensionData.id]);
+        mockDelegate.testClickingCalls(
+            item.$$('#remove-extension'), 'deleteItem',
+            [extensionData.id]);
       });
     });
   }
 
   return {
     registerTests: registerTests,
     TestNames: TestNames,
   };
 });