Add const char* overloads to ErrorSupport

Add const char* overloads to ErrorSupport

As these functions are usually called with string literals, doing so
out-of-lines the temporary string construction, saving about 60 KB in a
release build.

BUG=none
R=dgozman@chromium.org

Committed: https://chromium.googlesource.com/deps/inspector_protocol13768f332cacb5170d64b8fcce1887b78fec2d86

[dcheng, 2017-02-28 12:05:15]

dcheng@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-02-28 19:20:34]

Very interesting! Is this a common problem? Are there any techniques to find/fix
it in general?

lgtm

[dcheng, 2017-02-28 19:34:29]

On 2017/02/28 19:20:34, dgozman wrote:
> Very interesting! Is this a common problem? Are there any techniques to
find/fix
> it in general?
> 
> lgtm

It's semi-common unfortunately. I noticed this when looking into why the
generated devtool protocols are 1MB+ of code.
I have ideas for exposing this better through a dashboard, so we can find them
more easily, rather than relying on random code inspection.

[dcheng, 2017-02-28 19:35:06]

Description was changed from

==========
Add const char* overloads to ErrorSupport

As these functions are usually called with string literals, doing so
out-of-lines the temporary string construction, saving about 60 KB in a
release build.

BUG=none
==========

to

==========
Add const char* overloads to ErrorSupport

As these functions are usually called with string literals, doing so
out-of-lines the temporary string construction, saving about 60 KB in a
release build.

BUG=none
R=dgozman@chromium.org

Committed:
https://chromium.googlesource.com/deps/inspector_protocol13768f332cacb5170d64...
==========

[dcheng, 2017-02-28 19:35:07]

Committed patchset #1 (id:1) manually as
13768f332cacb5170d64b8fcce1887b78fec2d86 (presubmit successful).