Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Issue 2723453003: [ios] Improve toolbar in tab_grid (Closed)
Patch Set: Unsafe retained assign fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
index 4edb8fcfea36ce0361bdacd6da8d10689dcfac6c..c0c213fb8c16aae15196f504c9e59a68d007b446 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
@@ -19,17 +19,12 @@
#import "ios/clean/chrome/browser/ui/tab_grid/mdc_floating_button+cr_tab_grid.h"
#import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.h"
#import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_tab_cell.h"
-#import "ios/clean/chrome/browser/ui/tab_grid/ui_stack_view+cr_tab_grid.h"
+#import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
#error "This file requires ARC support."
#endif
-namespace {
-// Height of toolbar in tab grid.
-const CGFloat kToolbarHeight = 64.0f;
-}
-
@interface TabGridViewController ()<SettingsActions,
TabGridActions,
UICollectionViewDataSource,
@@ -37,7 +32,8 @@ const CGFloat kToolbarHeight = 64.0f;
SessionCellDelegate>
@property(nonatomic, weak) UICollectionView* grid;
@property(nonatomic, weak) UIView* noTabsOverlay;
-@property(nonatomic, strong) MDCFloatingButton* floatingNewTabButton;
+@property(nonatomic, weak) TabGridToolbar* toolbar;
+@property(nonatomic, weak) MDCFloatingButton* floatingNewTabButton;
@end
@implementation TabGridViewController
@@ -48,20 +44,10 @@ const CGFloat kToolbarHeight = 64.0f;
@synthesize tabCommandHandler = _tabCommandHandler;
@synthesize grid = _grid;
@synthesize noTabsOverlay = _noTabsOverlay;
+@synthesize toolbar = _toolbar;
@synthesize floatingNewTabButton = _floatingNewTabButton;
- (void)viewDidLoad {
- UIView* toolbar = [UIStackView cr_tabGridToolbarStackView];
- [self.view addSubview:toolbar];
-
- toolbar.translatesAutoresizingMaskIntoConstraints = NO;
- [NSLayoutConstraint activateConstraints:@[
- [toolbar.heightAnchor constraintEqualToConstant:kToolbarHeight],
- [toolbar.widthAnchor constraintEqualToAnchor:self.view.widthAnchor],
- [toolbar.topAnchor constraintEqualToAnchor:self.view.topAnchor],
- [toolbar.centerXAnchor constraintEqualToAnchor:self.view.centerXAnchor]
- ]];
-
TabGridCollectionViewLayout* layout =
[[TabGridCollectionViewLayout alloc] init];
UICollectionView* grid = [[UICollectionView alloc] initWithFrame:CGRectZero
@@ -77,21 +63,44 @@ const CGFloat kToolbarHeight = 64.0f;
forCellWithReuseIdentifier:[TabGridTabCell identifier]];
[NSLayoutConstraint activateConstraints:@[
- [self.grid.topAnchor constraintEqualToAnchor:toolbar.bottomAnchor],
+ [self.grid.topAnchor constraintEqualToAnchor:self.view.topAnchor],
[self.grid.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor],
[self.grid.leadingAnchor constraintEqualToAnchor:self.view.leadingAnchor],
[self.grid.trailingAnchor constraintEqualToAnchor:self.view.trailingAnchor],
]];
+
+ TabGridToolbar* toolbar = [[TabGridToolbar alloc] init];
+ self.toolbar = toolbar;
+ [self.view addSubview:self.toolbar];
+ self.toolbar.translatesAutoresizingMaskIntoConstraints = NO;
+ [NSLayoutConstraint activateConstraints:@[
+ [self.toolbar.topAnchor constraintEqualToAnchor:self.view.topAnchor],
+ [self.toolbar.heightAnchor
+ constraintEqualToAnchor:self.topLayoutGuide.heightAnchor
+ constant:self.toolbar.intrinsicContentSize.height],
+ [self.toolbar.leadingAnchor
+ constraintEqualToAnchor:self.view.leadingAnchor],
+ [self.toolbar.trailingAnchor
+ constraintEqualToAnchor:self.view.trailingAnchor]
+ ]];
}
- (void)viewWillAppear:(BOOL)animated {
- self.floatingNewTabButton = [MDCFloatingButton cr_tabGridNewTabButton];
+ MDCFloatingButton* floatingNewTabButton =
+ [MDCFloatingButton cr_tabGridNewTabButton];
+ self.floatingNewTabButton = floatingNewTabButton;
[self.floatingNewTabButton
setFrame:[MDCFloatingButton
cr_frameForTabGridNewTabButtonInRect:self.view.bounds]];
[self.view addSubview:self.floatingNewTabButton];
}
+- (void)viewDidLayoutSubviews {
+ [super viewDidLayoutSubviews];
+ self.grid.contentInset =
+ UIEdgeInsetsMake(CGRectGetMaxY(self.toolbar.frame), 0, 0, 0);
+}
+
- (UIStatusBarStyle)preferredStatusBarStyle {
return UIStatusBarStyleLightContent;
}
« no previous file with comments | « ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698